metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <...@git.apache.org>
Subject [GitHub] metron pull request #609: METRON-987: Allow stellar enrichments to be specif...
Date Thu, 08 Jun 2017 16:14:07 GMT
Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/metron/pull/609#discussion_r120932742
  
    --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/message/JSONFromPosition.java
---
    @@ -40,10 +40,12 @@ public JSONFromPosition(int position) {
     
       @Override
       public JSONObject get(Tuple tuple) {
    +    String s = null;
         try {
    -      return (JSONObject) parser.get().parse(new String(tuple.getBinary(position), "UTF8"));
    +      s =  new String(tuple.getBinary(position), "UTF8");
    --- End diff --
    
    Can we just use StandardCharsets.UTF_8 then, and not even worry about the string being
right?  I'm not sure where that alias is, so I'm not convinced it's guaranteed (although a
source proving me wrong would also be acceptable)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message