metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kylerichardson <...@git.apache.org>
Subject [GitHub] metron issue #612: METRON-962: Configuration Based Unit Tests and Add integr...
Date Fri, 09 Jun 2017 02:27:57 GMT
Github user kylerichardson commented on the issue:

    https://github.com/apache/metron/pull/612
  
    'GrokAsaParser' is legacy OpenSOC I believe. It has been broken for some time and when
I rewrote the ASA parser I did it as 'BasicAsaParser'.
    
    @justinleet Thanks for cleaning this up! I'm +1 for dropping 'GrokAsaParser'.
    
    -Kyle
    
    > On Jun 7, 2017, at 8:58 AM, justinleet <notifications@github.com> wrote:
    > 
    > @kylerichardson What is the difference between the BasicAsaParser and the GrokAsaParser?
Are you able to shed some light on why both exist? The motivation for the question is that
minor changes had to be made to the GrokAsaParser to get unit tests (and possibly the parser
itself working).
    > 
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub, or mute the thread.
    > 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message