metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...
Date Fri, 09 Jun 2017 20:04:06 GMT
Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/530#discussion_r121211536
  
    --- Diff: metron-extensions/metron-parser-extensions/metron-parser-bro-extension/metron-parser-bro/src/main/config/zookeeper/enrichments/bro.json
---
    @@ -0,0 +1,17 @@
    +{
    +    "enrichment" : {
    --- End diff --
    
    I don't think I made my point clearly enough.  I don't have a problem with having the
ability to add enrichments, indexing definitions, etc in an extension.  
    
    My point is that the defaults we provide should make as few assumptions about the environment
as possible. 
     For example, when I install the Bro parser extension from this PR, it is going to perform
GeoIP and malicious IP lookups.  That assumes that the environment in which I am installing
this has the Geo database setup correctly and a malicious IP table setup in HBase.  
    
    Are those fair assumptions to make?  It seems to me we should make as few assumptions
as possible so this can "just work" for the greatest number of users out there.  I would default
to no enrichments, for example.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message