metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <...@git.apache.org>
Subject [GitHub] metron pull request #607: METRON-982 add new rest api for storm supervisor s...
Date Mon, 19 Jun 2017 13:03:22 GMT
Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/metron/pull/607#discussion_r122700117
  
    --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/StormStatusServiceImpl.java
---
    @@ -49,6 +44,11 @@ public StormStatusServiceImpl(Environment environment, RestTemplate
restTemplate
       }
     
       @Override
    +  public SupervisorSummary getSupervisorSummary(){
    +    return restTemplate.getForObject("http://" + environment.getProperty(STORM_UI_SPRING_PROPERTY)
+ SUPERVISOR_SUMMARY_URL, SupervisorSummary.class);
    --- End diff --
    
    Should have pointed this out the other day, but that PR is in now, so this probably should
be:
    ```
    return restTemplate.getForObject(getStormUiProperty() + SUPERVISOR_SUMMARY_URL, SupervisorSummary.class);
    ```
    
    Ping me if there's any issues and I'm happy to do more than just glance at it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message