metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] metron issue #608: METRON-986 Enhance Fastcapa to Support Intel X520
Date Mon, 19 Jun 2017 21:34:06 GMT
Github user nickwallen commented on the issue:

    https://github.com/apache/metron/pull/608
  
    What we have **should** work out-of-the-box for most NICs.  Of course, I have only been
able to test on the x520 and Cisco VNICs, so that is all I can really be sure of.
    
    If changes would be needed, it would likely be in the initialization of the `rte_eth_conf`
and `rte_eth_txconf` structs. The defaults are currently provided in `nic.c`.  
    
    I was going to make this configurable, but decided not to in this PR due to the amount
of work needed.  I would have had to define configurable values that populate all of the possible
fields in each of these structs (which are quite numerous).  I would have had to allow configuration
of these values via the config file, rather than just the command-line, since they are so
numerous.
    
    There is also the challenge of how to allow a user to dynamically configure values that
are effectively macros, if that is even possible. For example, how should a user define something
like the following in a configuration file?  I'd have to dig for a good way to handle this.
    
    ```
    static const struct rte_eth_conf rx_conf_default = {
         .rxmode = {
             .mq_mode = ETH_MQ_RX_RSS,
             ...
          }
    }
    ```
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message