metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mmiklavc <>
Subject [GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...
Date Tue, 20 Jun 2017 21:07:11 GMT
Github user mmiklavc commented on a diff in the pull request:
    --- Diff: metron-platform/metron-extensions/metron-parser-extensions/metron-parser-bro-extension/metron-parser-bro-assembly/src/main/assembly/assembly.xml
    @@ -0,0 +1,53 @@
    +  Licensed to the Apache Software
    +	Foundation (ASF) under one or more contributor license agreements. See the
    +	NOTICE file distributed with this work for additional information regarding
    +	copyright ownership. The ASF licenses this file to You under the Apache License,
    +	Version 2.0 (the "License"); you may not use this file except in compliance
    +	with the License. You may obtain a copy of the License at
    +	Unless required by applicable law or agreed to in writing, software distributed
    +	under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES
    +	OR CONDITIONS OF ANY KIND, either express or implied. See the License for
    +  the specific language governing permissions and limitations under the License.
    +  -->
    --- End diff --
    Can you explain a bit the reasoning behind going with this 4 module (1 parent, 3 submodules)
layout? I see a parent module per parser and then 3 submodules packaging that creates a jar,
a bundle, and a tar.gz, per these respective projects:
    - metron-parser-bro-extension - parent pom
    - metron-parser-bro - jar
    - metron-parser-bro-assembly - tar.gz
    - metron-parser-bro-bundle - bundle
    It seems like we might be able to handle this with 2 modules. Maybe one would be the parent
that builds the bundle file and tar.gz while the child contains source code and produces a
jar. I know there are some best practices that often come out of the Maven community and Sonatype,
but some added explanation here would be of help. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message