metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mmiklavc <...@git.apache.org>
Subject [GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...
Date Tue, 20 Jun 2017 21:07:15 GMT
Github user mmiklavc commented on a diff in the pull request:

    https://github.com/apache/metron/pull/530#discussion_r123033739
  
    --- Diff: bundles-maven-plugin/.gitignore ---
    @@ -0,0 +1,16 @@
    +target
    +.project
    +.settings
    +.classpath
    +nbactions.xml
    +nb-configuration.xml
    +.DS_Store
    +.metadata
    +.recommenders
    +
    +# Intellij
    --- End diff --
    
    It's a small nit, but many of these gitignore additions are already included in the root
.gitignore. Can we remove the duplicates? Child directories inherit from the root gitignore.
    
    > Patterns read from a .gitignore file in the same directory as the path, or in any
parent directory, with patterns in the higher level files (up to the toplevel of the work
tree) being overridden by those in lower level files down to the directory containing the
file.
    
    https://git-scm.com/docs/gitignore


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message