metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mmiklavc <...@git.apache.org>
Subject [GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...
Date Tue, 20 Jun 2017 21:07:15 GMT
Github user mmiklavc commented on a diff in the pull request:

    https://github.com/apache/metron/pull/530#discussion_r123080563
  
    --- Diff: metron-platform/metron-extensions/metron-parser-extensions/metron-parser-bro-extension/metron-parser-bro/pom.xml
---
    @@ -0,0 +1,165 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +  Licensed to the Apache Software
    +	Foundation (ASF) under one or more contributor license agreements. See the
    +	NOTICE file distributed with this work for additional information regarding
    +	copyright ownership. The ASF licenses this file to You under the Apache License,
    +	Version 2.0 (the "License"); you may not use this file except in compliance
    +	with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
    +	Unless required by applicable law or agreed to in writing, software distributed
    +	under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES
    +	OR CONDITIONS OF ANY KIND, either express or implied. See the License for
    +  the specific language governing permissions and limitations under the License.
    +  --><project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +    <modelVersion>4.0.0</modelVersion>
    +    <parent>
    +        <groupId>org.apache.metron</groupId>
    +        <artifactId>metron-parser-bro-extension</artifactId>
    +        <version>0.4.0</version>
    +    </parent>
    +    <artifactId>metron-parser-bro</artifactId>
    +    <version>0.4.0</version>
    +    <name>metron-parser-bro</name>
    +    <packaging>jar</packaging>
    +    <properties>
    +        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    +        <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
    +    </properties>
    +    <dependencies>
    +        <dependency>
    +            <groupId>org.apache.metron</groupId>
    +            <artifactId>metron-common</artifactId>
    +            <version>${project.parent.version}</version>
    +            <scope>provided</scope>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.apache.metron</groupId>
    +            <artifactId>metron-parsers</artifactId>
    +            <version>${project.parent.version}</version>
    +            <scope>provided</scope>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.atteo.classindex</groupId>
    +            <artifactId>classindex</artifactId>
    +            <version>${global_classindex_version}</version>
    +            <scope>provided</scope>
    +        </dependency>
    +        <!-- testing -->
    --- End diff --
    
    I think if we're  going to go through this level of refactoring it makes some sense to
extract some of the common functionality in these poms as well. For instance, these test deps
could be pulled into a separate maven module under metron-parser-extensions:
    ```
    <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
        <modelVersion>4.0.0</modelVersion>
        <parent>
            <groupId>org.apache.metron</groupId>
            <artifactId>metron-parser-extensions</artifactId>
            <version>0.4.0</version>
        </parent>
        <artifactId>metron-parser-testlib</artifactId>
        <version>0.4.0</version>
        <name>metron-parser-testlib</name>
        <packaging>pom</packaging>
        <properties>
            <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
            <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
        </properties>
        <dependencies>
            <!-- testing -->
            <dependency>
                <groupId>org.apache.metron</groupId>
                <artifactId>metron-parsers</artifactId>
                <version>${project.parent.version}</version>
                <type>test-jar</type>
            </dependency>
            <dependency>
                <groupId>org.apache.metron</groupId>
                <artifactId>metron-enrichment</artifactId>
                <version>${project.parent.version}</version>
                <type>test-jar</type>
            </dependency>
            <dependency>
                <groupId>junit</groupId>
                <artifactId>junit</artifactId>
                <version>${global_junit_version}</version>
            </dependency>
            <dependency>
                <groupId>org.apache.metron</groupId>
                <artifactId>metron-test-utilities</artifactId>
                <version>${project.parent.version}</version>
                <scope>test</scope>
            </dependency>
            <dependency>
                <groupId>org.apache.metron</groupId>
                <artifactId>metron-integration-test</artifactId>
                <version>${project.parent.version}</version>
            </dependency>
            <dependency>
                <groupId>org.apache.kafka</groupId>
                <artifactId>kafka_2.10</artifactId>
                <version>${global_kafka_version}</version>
                <classifier>test</classifier>
                <exclusions>
                    <exclusion>
                        <artifactId>slf4j-log4j12</artifactId>
                        <groupId>org.slf4j</groupId>
                    </exclusion>
                    <exclusion>
                        <groupId>log4j</groupId>
                        <artifactId>log4j</artifactId>
                    </exclusion>
                </exclusions>
            </dependency>
            <dependency>
                <groupId>org.apache.kafka</groupId>
                <artifactId>kafka-clients</artifactId>
                <version>${global_kafka_version}</version>
                <classifier>test</classifier>
                <exclusions>
                    <exclusion>
                        <groupId>log4j</groupId>
                        <artifactId>log4j</artifactId>
                    </exclusion>
                </exclusions>
            </dependency>
        </dependencies>
    </project>
    ```
    And then included as a test dep as follows:
    ```
            <dependency>
                <groupId>org.apache.metron</groupId>
                <artifactId>metron-parser-testlib</artifactId>
                <version>${project.parent.version}</version>
                <scope>test</scope>
            </dependency>
    ```
    Note that scope=test is no longer required in the test project. Compile scope (the Maven
default) dependencies of a module that is declared as scope=test will also be pulled in as
scope test.
    
    **Reference:** https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message