metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] metron pull request #613: METRON-990: Clean up and organize flux properties
Date Wed, 21 Jun 2017 15:12:53 GMT
Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/613#discussion_r123267781
  
    --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/templates/enrichment.properties.j2
---
    @@ -16,72 +16,48 @@
     # limitations under the License.
     #}
     
    -##### Kafka #####
    +##### Storm #####
    +enrichment.workers={{enrichment_workers}}
    +enrichment.acker.executors={{enrichment_acker_executors}}
    +topology.worker.childopts={{enrichment_topology_worker_childopts}}
    +topology.auto-credentials={{topology_auto_credentials}}
    +topology.max.spout.pending={{enrichment_topology_max_spout_pending}}
     
    +##### Kafka #####
     kafka.zk={{zookeeper_quorum}}
     kafka.broker={{kafka_brokers}}
    -kafka.security.protocol={{kafka_security_protocol}}
    -topology.worker.childopts={{topology_worker_childopts}}
    -topology.auto-credentials={{topology_auto_credentials}}
    -enrichment.output.topic=indexing
    -enrichment.error.topic=indexing
    -threat.intel.error.topic=indexing
    -
    -##### Metrics #####
    -
    -#reporters
    -org.apache.metron.metrics.reporter.graphite=true
    -org.apache.metron.metrics.reporter.console=false
    -org.apache.metron.metrics.reporter.jmx=false
    -
    -#Graphite Addresses
    +kafka.security.protocol=PLAINTEXT
    --- End diff --
    
    Should this get the `kafka.security.protocol` from the configuration parameter like it
does for Indexing?
    
    ```
    kafka.security.protocol={{kafka_security_protocol}}
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message