metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] metron pull request #613: METRON-990: Clean up and organize flux properties
Date Wed, 21 Jun 2017 21:35:51 GMT
Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/613#discussion_r123372371
  
    --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml
---
    @@ -253,69 +253,295 @@
             </value-attributes>
         </property>
         <property>
    -        <name>global-json</name>
    -        <display-name>global.json template</display-name>
    -        <description>This is the jinja template for global.json file</description>
    -        <value>
    -{
    -"es.clustername": "{{ es_cluster_name }}",
    -"es.ip": "{{ es_url }}",
    -"es.date.format": "yyyy.MM.dd.HH",
    -"parser.error.topic": "indexing"
    -}
    -        </value>
    +        <name>es_date_format</name>
    +        <description>Elasticsearch Date Format</description>
    +        <value>yyyy.MM.dd.HH</value>
    +        <display-name>Elasticsearch Date Format</display-name>
    +    </property>
    +    <property>
    +        <name>parser_error_topic</name>
    +        <description>Parser Error Topic</description>
    +        <value>indexing</value>
    +        <display-name>Parser Error Topic</display-name>
    +    </property>
    +    <property>
    +        <name>enrichment_workers</name>
    --- End diff --
    
    Great.  Feel free to do as a separate PR, if you like.  Definitely not needed as part
of this one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message