metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mmiklavc <...@git.apache.org>
Subject [GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...
Date Wed, 21 Jun 2017 21:44:58 GMT
Github user mmiklavc commented on a diff in the pull request:

    https://github.com/apache/metron/pull/530#discussion_r123374273
  
    --- Diff: metron-platform/metron-extensions/metron-parser-extensions/metron-parser-bro-extension/metron-parser-bro/pom.xml
---
    @@ -0,0 +1,165 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +  Licensed to the Apache Software
    +	Foundation (ASF) under one or more contributor license agreements. See the
    +	NOTICE file distributed with this work for additional information regarding
    +	copyright ownership. The ASF licenses this file to You under the Apache License,
    +	Version 2.0 (the "License"); you may not use this file except in compliance
    +	with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
    +	Unless required by applicable law or agreed to in writing, software distributed
    +	under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES
    +	OR CONDITIONS OF ANY KIND, either express or implied. See the License for
    +  the specific language governing permissions and limitations under the License.
    +  --><project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +    <modelVersion>4.0.0</modelVersion>
    +    <parent>
    +        <groupId>org.apache.metron</groupId>
    +        <artifactId>metron-parser-bro-extension</artifactId>
    +        <version>0.4.0</version>
    +    </parent>
    +    <artifactId>metron-parser-bro</artifactId>
    +    <version>0.4.0</version>
    +    <name>metron-parser-bro</name>
    +    <packaging>jar</packaging>
    +    <properties>
    +        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    +        <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
    +    </properties>
    +    <dependencies>
    +        <dependency>
    +            <groupId>org.apache.metron</groupId>
    +            <artifactId>metron-common</artifactId>
    +            <version>${project.parent.version}</version>
    +            <scope>provided</scope>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.apache.metron</groupId>
    +            <artifactId>metron-parsers</artifactId>
    +            <version>${project.parent.version}</version>
    +            <scope>provided</scope>
    +        </dependency>
    +        <dependency>
    +            <groupId>org.atteo.classindex</groupId>
    +            <artifactId>classindex</artifactId>
    +            <version>${global_classindex_version}</version>
    +            <scope>provided</scope>
    +        </dependency>
    +        <!-- testing -->
    --- End diff --
    
    I bet it's because we are declaring them as compile-time dependencies within the test
module, even though we're only using them as test dependencies. I wonder if we can take into
account the pom type of "pom" and ignore it outright in that context. I think we only care
about things we're actually packaging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message