metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <...@git.apache.org>
Subject [GitHub] metron pull request #602: METRON-906: Rest service storm configuration does ...
Date Thu, 01 Jun 2017 13:25:05 GMT
GitHub user justinleet opened a pull request:

    https://github.com/apache/metron/pull/602

    METRON-906: Rest service storm configuration does not allow for proper URLs

    ## Contributor Comments
    Allows for protocol to be used in the Storm REST URL (e.g. http:// and https://).  Prior
to this, http:// was automatically prepended.  In the event that no protocol is given, http://
will be prepended for backwards compatibility.
    
    Unit tests are added to ensure that the protocol is handled properly. Full dev was spun
up to ensure that things still functioned as expected, with the protocol provided.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines
and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).

    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed
or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested
manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the
root incubating-metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] Have you verified the basic functionality of the build by building and running locally
with Vagrant full-dev environment or the equivalent?
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal
repository such that your branches are built there before submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/justinleet/metron METRON-906

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/602.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #602
    
----
commit b32b0d7a784595dba504354ea55a7e8e90f7bd7f
Author: justinjleet <justinjleet@gmail.com>
Date:   2017-05-09T15:20:48Z

    initial change

commit 4912ae3373fbd670803508919651d7dc68040425
Author: justinjleet <justinjleet@gmail.com>
Date:   2017-06-01T12:01:47Z

    Backwards compatibility

commit deca9d5f8435d47051c3a01ca0014dc7df3c5b5f
Author: justinjleet <justinjleet@gmail.com>
Date:   2017-06-01T13:23:37Z

    changed comment

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message