metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mattf-horton <...@git.apache.org>
Subject [GitHub] metron pull request #605: Metron-979 markdown errors in site-book
Date Fri, 02 Jun 2017 01:10:25 GMT
GitHub user mattf-horton opened a pull request:

    https://github.com/apache/metron/pull/605

    Metron-979 markdown errors in site-book

    ## Contributor Comments
    Fixed multiple problems in markdown docs, mostly related to triple-backtick codeblocks
nesting inside numbered lists.  I now understand that blank lines are not allowed within a
codeblock nested under a numbered list item, although at the top level (under body text) blank
lines in codeblocks are okay.
    
    A few of these changes are for consistency or editorial improvement, but most of them
fix actual rendering errors in the doxia site build, without breaking Github rendering.
    
    
    ## Pull Request Checklist
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).

    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    
    ### For code changes: N/A
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered
by building and verifying the site-book? 
        - Yes, verified in doxia build and in github.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattf-horton/incubator-metron METRON-979

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/605.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #605
    
----
commit 9a7bbaaa70cb202d3f8b5fc0de01a3cf45f756d2
Author: mattf-horton <mfoley@hortonworks.com>
Date:   2017-06-02T00:28:05Z

    METRON-979 markdown errors in site-book

commit 8347f1a0b924155c95af38c1e4aba200ce7ab4d1
Author: mattf-horton <mfoley@hortonworks.com>
Date:   2017-06-02T00:39:23Z

    more of same

commit 9f42a4f4ad0d364d647026ef74e0d2f33306a70a
Author: mattf-horton <mfoley@hortonworks.com>
Date:   2017-06-02T01:03:19Z

    and more

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message