metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cestella <...@git.apache.org>
Subject [GitHub] metron pull request #606: METRON-980: Short circuit operations for Stellar
Date Fri, 02 Jun 2017 04:39:59 GMT
GitHub user cestella opened a pull request:

    https://github.com/apache/metron/pull/606

    METRON-980: Short circuit operations for Stellar

    ## Contributor Comments
    Stellar does not currently contain short circuit operations. In most languages, this is
an important optimization, but for Stellar on Metron, this is a requirement due to the fact
that some variables may be null legitimately and we cannot create multi-line conditionals
or temporary variables at the moment.
    The short circuit operations supported:
    * short circuited `or` (e.g. `true or FUNC(...)` would never execute `FUNC`)
    * short circuited `and` (e.g. `false and FUNC(...)` would never execute `FUNC`)
    * short circuited if/then/else (e.g. `if true then FUNC(...) else FUNC2(...)` will never
call `FUNC2`)
    
    This should be tested entirely via the unit tests for Stellar.  Please review the tests
and ensure I've not missed a test case, reviewers.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines
and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).

    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed
or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested
manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the
root incubating-metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

    - [x] Have you verified the basic functionality of the build by building and running locally
with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered
by building and verifying the site-book? If not then run the following commands and the verify
changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal
repository such that your branches are built there before submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cestella/incubator-metron short_circuit_stellar

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/606.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #606
    
----
commit c2a65b200c49a0ab748edf116f23a51b4811e66f
Author: cstella <cestella@gmail.com>
Date:   2017-05-15T16:18:07Z

    Added test to verify shortcutting works.

commit 0c86c2a93216b9f0418e22b78de56c0facb6f55a
Author: cstella <cestella@gmail.com>
Date:   2017-05-23T17:59:41Z

    Merge branch 'master' into short_circuit_stellar

commit d038f5c8738b11bba61d3f6cf07abf78b434f883
Author: cstella <cestella@gmail.com>
Date:   2017-06-02T04:21:30Z

    Short circuit operations.

commit ac9ee328ba56296621a982d279a7c356d8a6d82c
Author: cstella <cestella@gmail.com>
Date:   2017-06-02T04:21:54Z

    Merge branch 'master' into short_circuit_stellar

commit 7fe0e9b636e3fc6e7642af36de5d57261f6f3b78
Author: cstella <cestella@gmail.com>
Date:   2017-06-02T04:31:46Z

    Updating some docs.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message