metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jjmeyer0 <...@git.apache.org>
Subject [GitHub] metron issue #633: METRON-1008: Updating travis to use trusty, moved install...
Date Wed, 05 Jul 2017 21:58:56 GMT
Github user jjmeyer0 commented on the issue:

    https://github.com/apache/metron/pull/633
  
    Quote from @justinleet 
    > I'd be inclined towards avoiding splitting the build if we were only getting a couple
minutes out of it. I'm a little worried about being able to get three slots on the occasionally
stretched Apache setup. Integration tests and building are the long poles in the tent, so
splitting out the other tests doesn't really save us much time here, unfortunately.
    
    I agree, I have reverted this.
    
    
    
    Quote from @ottobackwards 
    > I'm going to be honest. Now that we have the builds kind of working again, I'm a
little hesitant to change them for anything but an absolute certainty of a return, that we
completely understand.
    > 
    > I think the travis build strategy should be a longer living branch maybe.
    
    I reverted the multiple env changes, as I agree, it's not worth the small chunk of time
that was shaved off. However, I think the rest of these changes can be helpful for the following
reasons:
    
    * moving the license verification to an earlier step can help the build fail fast. Forgetting
to update the dependency file can be a common mistake. Failing earlier might save time and
travis resources.
    * I believe moving to trusty was recommended by travis-ci
    * using travis' install step for the `mvn install`. No benefit that I know of. I just
believe `mvn install` should happen here.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message