metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ottobackwards <...@git.apache.org>
Subject [GitHub] metron pull request #635: METRON-1018: Integration tests should reference fl...
Date Thu, 06 Jul 2017 13:55:18 GMT
Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/635#discussion_r125905841
  
    --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchIndexingIntegrationTest.java
---
    @@ -102,11 +102,16 @@ public void setAdditionalProperties(Properties topologyProperties)
{
         topologyProperties.setProperty("es.clustername", "metron");
         topologyProperties.setProperty("es.port", "9300");
         topologyProperties.setProperty("es.ip", "localhost");
    -    topologyProperties.setProperty("indexing.writer.class.name", "org.apache.metron.elasticsearch.writer.ElasticsearchWriter");
    +    topologyProperties.setProperty("indexing_writer_class_name", "org.apache.metron.elasticsearch.writer.ElasticsearchWriter");
       }
     
       @Override
       public String cleanField(String field) {
         return field;
       }
    --- End diff --
    
    I am not sure about having things live in ambari vs. things being referenced by ambari.
That doesn't seem right, like a violation of a separation of concerns.  I know we do this
other places too ( like the ES Templates, although I'm trying to move away from that ).  
I am not sure I have a different way to suggest, but I want to bring up the point.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message