metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ottobackwards <...@git.apache.org>
Subject [GitHub] metron pull request #641: METRON-539: added HASH function for stellar.
Date Tue, 11 Jul 2017 01:49:31 GMT
Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/641#discussion_r126577935
  
    --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/HashFunctions.java
---
    @@ -0,0 +1,85 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.stellar.dsl.functions;
    +
    +import com.google.common.io.BaseEncoding;
    +import org.apache.commons.lang3.SerializationUtils;
    +import org.apache.metron.stellar.dsl.BaseStellarFunction;
    +import org.apache.metron.stellar.dsl.Stellar;
    +
    +import java.io.Serializable;
    +import java.nio.charset.StandardCharsets;
    +import java.security.MessageDigest;
    +import java.security.NoSuchAlgorithmException;
    +import java.util.List;
    +
    +public class HashFunctions {
    +  @Stellar(
    +    name = "HASH",
    +    description = "Hashes a given value using the given hashing algorithm and returns
a hex encoded string. This function only hashes " +
    +      "strings and values that implement java.io.Serializable.",
    +    params = {
    +      "toHash - value to hash.",
    +      "hashType - A valid string representation of an algorithm supported by java.security.MessageDigest.",
    +    },
    +    returns = "A hex representation of a hashed value using the given hashing algorithm.
If either argument is " +
    +      "null then null will be returned. If the type of 'toHash' is neither a string nor
of type java.io.Serializable, " +
    +      "then null is returned."
    +  )
    +  public static class Hash extends BaseStellarFunction {
    --- End diff --
    
    I have no preference.  I picked the string thinking of the return of the call being for
'information' and display only.  Like from the shell.  I think that we should do the 'get'
no params calls the same though, i'd change to list if that is what makes sense


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message