metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <...@git.apache.org>
Subject [GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...
Date Tue, 11 Jul 2017 12:25:50 GMT
Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/metron/pull/620#discussion_r126672638
  
    --- Diff: metron-interface/metron-alerts/src/app/model/alert.ts ---
    @@ -0,0 +1,44 @@
    +export class Alert {
    --- End diff --
    
    I haven't been a part of the review a whole lot, so forgive me if I'm asking a question
that's already been answered.  This `Alert` class seems very Snort specific, but `is_alert`
can potentially show up as a result of any of our input data.  Shouldn't this be relatively
abstract and limited to the fields that are essential for the alert?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message