metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ottobackwards <>
Subject [GitHub] metron pull request #641: METRON-539: added HASH function for stellar.
Date Tue, 11 Jul 2017 21:16:05 GMT
Github user ottobackwards commented on a diff in the pull request:
    --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/
    @@ -0,0 +1,85 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.stellar.dsl.functions;
    +import org.apache.commons.lang3.SerializationUtils;
    +import org.apache.metron.stellar.dsl.BaseStellarFunction;
    +import org.apache.metron.stellar.dsl.Stellar;
    +import java.nio.charset.StandardCharsets;
    +import java.util.List;
    +public class HashFunctions {
    +  @Stellar(
    +    name = "HASH",
    --- End diff --
    I am not sure that should bleed through here.  While we may limit
ourselves in some places to having stellar conform to java limitations and behaviors, and
other things, we don't really limit ourselves explicitly to java types.  The idea that the
user 'knows' the type of the entity in a stellar statement in java.... doesn't seem right.
    While this limitation may be true and enforced, I am not sure it should be expressed this
way explicitly.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message