metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iraghumitra <...@git.apache.org>
Subject [GitHub] metron pull request #620: Metron-988: UI for viewing alerts generated by Met...
Date Wed, 12 Jul 2017 13:06:44 GMT
Github user iraghumitra commented on a diff in the pull request:

    https://github.com/apache/metron/pull/620#discussion_r126947986
  
    --- Diff: metron-interface/metron-alerts/src/app/alerts/saved-searches/saved-searches.component.ts
---
    @@ -0,0 +1,124 @@
    +import { Component, OnInit } from '@angular/core';
    +import {Router} from '@angular/router';
    +import {Observable} from 'rxjs/Rx';
    +
    +import {SaveSearchService} from '../../service/save-search.service';
    +import {SaveSearch} from '../../model/save-search';
    +import {MetronDialogBox} from '../../shared/metron-dialog-box';
    +import {NUM_SAVED_SEARCH} from '../../utils/constants';
    +
    +@Component({
    +  selector: 'app-saved-searches',
    +  templateUrl: './saved-searches.component.html',
    +  styleUrls: ['./saved-searches.component.scss']
    +})
    +export class SavedSearchesComponent implements OnInit {
    +
    +  searches: SaveSearch[];
    +  recentSearcheObj: SaveSearch[];
    +  savedSearches: any = {};
    --- End diff --
    
    There was a separate model to pass data to collapse component the type declaration for
it was missing here. Since i was looking at the code after a while i got a chance to improve
now :). The code looks much better now. In gist I fixed this 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message