metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ottobackwards <...@git.apache.org>
Subject [GitHub] metron pull request #481: METRON-322 Global Batching and Flushing
Date Wed, 12 Jul 2017 19:47:28 GMT
Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/481#discussion_r127053228
  
    --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/bolt/BulkMessageWriterBolt.java
---
    @@ -92,24 +177,58 @@ public void prepare(Map stormConf, TopologyContext context, OutputCollector
coll
           configurationTransformation = x -> x;
         }
         try {
    -      bulkMessageWriter.init(stormConf,
    -                             context,
    -                             configurationTransformation.apply(new IndexingWriterConfiguration(bulkMessageWriter.getName(),
    -                             getConfigurations()))
    -                            );
    +      WriterConfiguration writerconf = configurationTransformation.apply(
    +              new IndexingWriterConfiguration(bulkMessageWriter.getName(), getConfigurations()));
    +      if (defaultBatchTimeout == 0) {
    +        //This means getComponentConfiguration was never called to initialize defaultBatchTimeout,
    +        //probably because we are in a unit test scenario.  So calculate it here.
    +        BatchTimeoutHelper timeoutHelper = new BatchTimeoutHelper(writerconf::getAllConfiguredTimeouts,
batchTimeoutDivisor);
    +        defaultBatchTimeout = timeoutHelper.getDefaultBatchTimeout();
    +      }
    +      writerComponent.setDefaultBatchTimeout(defaultBatchTimeout);
    +      bulkMessageWriter.init(stormConf, context, writerconf);
         } catch (Exception e) {
           throw new RuntimeException(e);
         }
       }
     
    +  /**
    +   * Used only for unit testing.
    +   */
    --- End diff --
    
    Maybe we can name this testPrepare? So it is explicit to caller, who may not 'peek' inside
the source


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message