metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mattf-horton <...@git.apache.org>
Subject [GitHub] metron pull request #481: METRON-322 Global Batching and Flushing
Date Wed, 12 Jul 2017 21:25:28 GMT
Github user mattf-horton commented on a diff in the pull request:

    https://github.com/apache/metron/pull/481#discussion_r127076248
  
    --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/writer/SingleBatchConfigurationFacade.java
---
    @@ -18,6 +18,8 @@
     
     package org.apache.metron.common.configuration.writer;
     
    +import java.util.ArrayList;
    +import java.util.List;
     import java.util.Map;
     
    --- End diff --
    
    Well, there's some weirdness in this stuff, and I didn't try to get rid of it lest I break
something I didn't understand.  In this case (and other places), it appears that non-batched
writers are essentially faked by using batched writers with a batchSize of "1".  Doesn't seem
real efficient to me, but obviously decreases the overall quantity of code and complexity
of testing.  Anyway, since I only did a trivial change to this file, I didn't feel obligated
to try to explain it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message