metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From justinleet <...@git.apache.org>
Subject [GitHub] metron pull request #635: METRON-1018: Integration tests should reference fl...
Date Fri, 14 Jul 2017 15:33:54 GMT
Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/metron/pull/635#discussion_r127484425
  
    --- Diff: metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchIndexingIntegrationTest.java
---
    @@ -102,11 +102,16 @@ public void setAdditionalProperties(Properties topologyProperties)
{
         topologyProperties.setProperty("es.clustername", "metron");
         topologyProperties.setProperty("es.port", "9300");
         topologyProperties.setProperty("es.ip", "localhost");
    -    topologyProperties.setProperty("indexing.writer.class.name", "org.apache.metron.elasticsearch.writer.ElasticsearchWriter");
    +    topologyProperties.setProperty("indexing_writer_class_name", "org.apache.metron.elasticsearch.writer.ElasticsearchWriter");
       }
     
       @Override
       public String cleanField(String field) {
         return field;
       }
    --- End diff --
    
    I do agree it does seem like a violation of separation of concerns, but to be honest,
I'm not terribly concerned about it in this case.
    
    The copy-resources seems reasonable, if it's not too much work, but given this particular
problem, I'm mostly content with just fixing it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message