metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mmiklavc <...@git.apache.org>
Subject [GitHub] metron issue #665: METRON-1060: Add performance timing logging to enrichment...
Date Fri, 28 Jul 2017 18:00:18 GMT
Github user mmiklavc commented on the issue:

    https://github.com/apache/metron/pull/665
  
    Hi @ottobackwards I actually took this advice and have a commit coming your way. I extracted
functionality into a PerformanceLogger class that allows you to specify a percentage probability
for logging the timing in the global config. A value of 1 logs roughly 1% of statements, 100
will log all statements. I could use some feedback on the approach I took for instantiating
the logger - I used a local member variable instead of a static variable. The reason being
that the logger maintains a Map<String, Long> of marked times. Since multiple executors
may exist within a single worker JVM, it seemed likely that they might trample one another.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message