metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mattf-horton <...@git.apache.org>
Subject [GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...
Date Fri, 28 Jul 2017 21:52:33 GMT
Github user mattf-horton commented on a diff in the pull request:

    https://github.com/apache/metron/pull/530#discussion_r129968508
  
    --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/util/VFSClassloaderUtil.java
---
    @@ -0,0 +1,178 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.bundles.util;
    +
    +import org.apache.accumulo.start.classloader.vfs.UniqueFileReplicator;
    +import org.apache.commons.vfs2.*;
    +import org.apache.commons.vfs2.cache.SoftRefFilesCache;
    +import org.apache.commons.vfs2.impl.DefaultFileSystemManager;
    +import org.apache.commons.vfs2.impl.FileContentInfoFilenameFactory;
    +import org.apache.commons.vfs2.impl.VFSClassLoader;
    +import org.apache.commons.vfs2.provider.hdfs.HdfsFileProvider;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.io.File;
    +import java.util.ArrayList;
    +import java.util.Optional;
    +
    +public class VFSClassloaderUtil {
    +  private static final Logger LOG = LoggerFactory.getLogger(VFSClassloaderUtil.class);
    +
    +  /**
    +   * Create a FileSystem manager suitable for our purposes.
    +   * This manager supports files of the following types:
    +   * * res - resource files
    +   * * jar
    +   * * tar
    +   * * bz2
    +   * * tgz
    +   * * zip
    +   * * HDFS
    +   * * FTP
    +   * * HTTP/S
    +   * * file
    +   * @return
    +   * @throws FileSystemException
    +   */
    +  public static FileSystemManager generateVfs() throws FileSystemException {
    +    return generateVfs(null);
    +  }
    +  public static FileSystemManager generateVfs(String jarExtensionToRegister) throws FileSystemException
{
    +    DefaultFileSystemManager vfs = new DefaultFileSystemManager();
    +
    +    if(jarExtensionToRegister == null || StringUtils.isBlank(jarExtensionToRegister)
) {
    +      vfs.addExtensionMap(jarExtensionToRegister, "jar");
    +      vfs.addProvider(jarExtensionToRegister, new org.apache.commons.vfs2.provider.jar.JarFileProvider());
    +    }
    --- End diff --
    
    This doesn't seem right.  Did you perhaps intend the negative of the conditional, ie
    `if (jarExtensionToRegister != null && !StringUtils.isBlank(jarExtensionToRegister)
) {...`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message