metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From simonellistonball <...@git.apache.org>
Subject [GitHub] metron pull request #674: METRON-681 CSVConverter should trim key and values
Date Mon, 31 Jul 2017 12:45:21 GMT
Github user simonellistonball commented on a diff in the pull request:

    https://github.com/apache/metron/pull/674#discussion_r130342209
  
    --- Diff: metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/csv/CSVParserTest.java
---
    @@ -87,15 +87,15 @@ public void test() throws IOException {
           Assert.assertEquals("grok", o.get("col3"));
         }
         {
    -      String line = "foo, bar, grok";
    +      String line = " foo , bar , grok ";
    --- End diff --
    
    This should really be implemented as a separate test function (additional) since we're
adding functionality here. you can definitely use the same form, but we're testing a different
unit of functionality.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message