metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Leet <>
Subject Re: Code style change requires vote?
Date Mon, 31 Jul 2017 19:30:24 GMT
That PR apparently got merged; I should have noted on the PR that this
thread got started.

Now there's a new potentially a new question: If that change required a
vote, what's the way we want to handle it?  Do we revert it or leave it and
just follow-on with a PR for any changes we choose to make during
discussion / vote?

Obviously, this is moot if the answer is we don't need a vote since that PR
did have the appropriate +1's.  At that point, I'd send an email calling it
out and make the appropriate wiki changes for getting people setup.

On Mon, Jul 31, 2017 at 1:50 PM, Justin Leet <> wrote:

> Hi all,
> There was a bit of confusion on code style on at least one ticket,
> indirectly related to  For a
> refresher (and also because GitHub is being iffy today), that PR is about
> moving to the Google Code Style as discussed in [DISCUSS] Code Style
> <>
> The feedback in that thread was positive, but no formal vote was done.
> I've found at least one vote thread for dev guidelines in the past, but
> it's also not part of the bylaws page itself.  Does this require just
> discussion/community consensus, or does it require (or do we just want) a
> vote?  And is that in line with what other projects tend to do (if we
> choose to fo
> If we're of the opinion that it requires a vote, I'll happy to kick up a
> discuss thread with the proposed change, get feedback, and run a vote.  It
> just delays when the change hits.

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message