metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From merrimanr <>
Subject [GitHub] metron pull request #636: METRON-1022: Elasticsearch REST endpoint
Date Thu, 06 Jul 2017 20:16:05 GMT
GitHub user merrimanr opened a pull request:

    METRON-1022: Elasticsearch REST endpoint

    ## Contributor Comments
    The PR adds a simple Elasticsearch REST endpoint that can execute simple queries.  This
will serve as the foundation for building more complex Elasticsearch functions.
    This can be tested with integration tests or in full dev.  To test is full dev, navigate
to Swagger through Ambari and look for the "search-controller".  Here you can perform simple
queries against data in Elasticsearch.  For example, posting this query should give back correct
search results:
      "from": 0,
      "indices": [
        "bro", "snort"
      "query": "*",
      "size": 10,
      "sort": [
          "field": "timestamp",
          "sortOrder": "desc"
    Note:  Swagger gives an example query with sortOrder = 'DESC'.  As of now this needs to
be lowercase but I'm considering changing it to accept both.  
    I still need to come up with a good description and add it to the README so that is still
pending.  Still wanted to put this up for review as it is fairly large and the first time
any Elasticsearch-related code has been added to REST.  Looking forward to the community's
    ## Pull Request Checklist
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](
for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](
for complete smoke testing guides.  
    In order to streamline the review of the contribution we ask you follow these guidelines
and ask you to double check the following:
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](

    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed
or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested
    - [x] Have you ensured that the full suite of tests and checks have been executed in the
root incubating-metron folder via:
      mvn -q clean integration-test install && build_utils/ 
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](

    - [x] Have you verified the basic functionality of the build by building and running locally
with Vagrant full-dev environment or the equivalent?
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered
by building and verifying the site-book? If not then run the following commands and the verify
changes via `site-book/target/site/index.html`:
      cd site-book
      mvn site
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci]( is set up for your personal
repository such that your branches are built there before submitting a pull request.

You can merge this pull request into a Git repository by running:

    $ git pull METRON-1022

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #636
commit 672e086f7905071f316cca51fd752f764ea46f11
Author: merrimanr <>
Date:   2017-07-06T20:02:36Z

    initial commit

commit e70533a150d2664f7221fba23ffdc82769fa0b0c
Author: merrimanr <>
Date:   2017-07-06T20:15:46Z

    fixed license headers


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message