metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Foley <mfo...@hortonworks.com>
Subject Re: [GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...
Date Thu, 17 Aug 2017 05:02:49 GMT
Eesh, sorry, please ignore.  This was incorrect, due to reading two diff blocks as contiguous.


On 8/16/17, 9:58 PM, "mattf-horton" <git@git.apache.org> wrote:

    Github user mattf-horton commented on a diff in the pull request:
    
        https://github.com/apache/metron/pull/530#discussion_r133623540
      
        --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/BundleClassLoaders.java
---
        @@ -119,8 +120,10 @@ public static void init(final FileSystemManager fileSystemManager,
final List<Fi
               if (bundleClassLoaders != null) {
                 throw new IllegalStateException("BundleClassloader already exists");
               }
        --- End diff --
        
        Sorry I missed this earlier.  The `initContext = null` has to be after this line,
otherwise you might destroy only half of the info.
    
    
    ---
    If your project is set up for it, you can reply to this email and have your
    reply appear on GitHub as well. If your project does not have this feature
    enabled and wishes so, or if the feature is enabled but not working, please
    contact infrastructure at infrastructure@apache.org or file a JIRA ticket
    with INFRA.
    ---
    
    

Mime
View raw message