metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mmiklavc <...@git.apache.org>
Subject [GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions
Date Wed, 02 Aug 2017 17:04:31 GMT
Github user mmiklavc commented on the issue:

    https://github.com/apache/metron/pull/530
  
    I'm back to looking through this again. A couple questions:
    1) I was under the impression that our local copy of the nar functionality would be a
hard fork that would naturally deviate from the NiFi based on our own requirements. In fact,
I thought the entire reason for our fork was because of features we needed that did not make
sense for NiFi. Do we really want to consider pulling patches going forward? I'm also in support
of keeping bundles-lib and bundles-maven-plugin at the top level, per @mattf-horton's comments,
though I don't think we want to have to worry about merges and cherry-picking commits, especially
since we forked local. Just a thought.
    2) Regarding the bundle loading, have you looked at the work from https://github.com/apache/metron/pull/468
for loading from HDFS? Any overlap there?
    
    Since this is a relatively large chunk of functionality, I decided that my testing methodology
for this feature should be use case driven. I'll report back with what I intend to work through
and @ottobackwards can let me know if I've missed or misinterpreted any aspects of this PR
in those use cases/tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message