metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mattf-horton <...@git.apache.org>
Subject [GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...
Date Tue, 08 Aug 2017 07:16:22 GMT
Github user mattf-horton commented on a diff in the pull request:

    https://github.com/apache/metron/pull/530#discussion_r131793643
  
    --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/bundle/Bundle.java ---
    @@ -0,0 +1,48 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.bundles.bundle;
    +
    +/**
    + * Represents a bundle that contains one or more extensions.
    + */
    +public class Bundle {
    +
    +    private final BundleDetails bundleDetails;
    +
    +    private final ClassLoader classLoader;
    +
    +    public Bundle(final BundleDetails bundleDetails, final ClassLoader classLoader) {
    +        this.bundleDetails = bundleDetails;
    +        this.classLoader = classLoader;
    +
    +        if (this.bundleDetails == null) {
    +            throw new IllegalStateException("BundleDetails cannot be null");
    +        }
    +
    +        if (this.classLoader == null) {
    +            throw new IllegalStateException("ClassLoader cannot be null");
    --- End diff --
    
    In the two throws above, wouldn't IllegalArgumentException be more appropriate?  (It is
also a RuntimeException.)  I suppose you're thinking it shouldn't have been called that way,
but since it was, this is a more empirical statement of the problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message