metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mattf-horton <...@git.apache.org>
Subject [GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...
Date Wed, 09 Aug 2017 19:15:44 GMT
Github user mattf-horton commented on a diff in the pull request:

    https://github.com/apache/metron/pull/530#discussion_r132279911
  
    --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/bundle/BundleDetails.java
---
    @@ -0,0 +1,191 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.bundles.bundle;
    +
    +import org.apache.commons.vfs2.FileObject;
    +
    +import java.text.ParseException;
    +import java.text.SimpleDateFormat;
    +import java.util.Date;
    +
    +/**
    + * Metadata about a bundle.
    + * the withCoordinates and withBundleFile properties are required
    + */
    +public class BundleDetails {
    +
    +    private final FileObject bundleFile;
    +
    +    private final BundleCoordinates coordinates;
    +    private final BundleCoordinates dependencyCoordinates;
    +
    +    private final String buildTag;
    +    private final String buildRevision;
    +    private final String buildBranch;
    +    private final String buildTimestamp;
    +    private final String buildJdk;
    +    private final String builtBy;
    +
    +    private BundleDetails(final Builder builder) {
    +        this.bundleFile = builder.bundleFile;
    +        this.coordinates = builder.coordinates;
    +        this.dependencyCoordinates = builder.dependencyCoordinates;
    +
    +        this.buildTag = builder.buildTag;
    +        this.buildRevision = builder.buildRevision;
    +        this.buildBranch = builder.buildBranch;
    +        this.buildTimestamp = builder.buildTimestamp;
    +        this.buildJdk = builder.buildJdk;
    +        this.builtBy = builder.builtBy;
    +
    +        if (this.coordinates == null) {
    +            if (this.bundleFile == null) {
    +                throw new IllegalStateException("Coordinate cannot be null");
    +            } else {
    +                throw new IllegalStateException("Coordinate cannot be null for " + this.bundleFile.getName());
    +            }
    +        }
    +
    +        if (this.bundleFile == null) {
    +            throw new IllegalStateException("bundleFile cannot be null for " + this.coordinates
    +                .getId());
    +        }
    +    }
    +
    +    public FileObject getBundleFile() {
    +        return bundleFile;
    +    }
    +
    +    public BundleCoordinates getCoordinates() {
    +        return coordinates;
    +    }
    +
    +    public BundleCoordinates getDependencyCoordinates() {
    +        return dependencyCoordinates;
    +    }
    +
    +    public String getBuildTag() {
    +        return buildTag;
    +    }
    +
    +    public String getBuildRevision() {
    +        return buildRevision;
    +    }
    +
    +    public String getBuildBranch() {
    +        return buildBranch;
    +    }
    +
    +    public String getBuildTimestamp() {
    +        return buildTimestamp;
    +    }
    +
    +    public String getBuildJdk() {
    +        return buildJdk;
    +    }
    +
    +    public String getBuiltBy() {
    +        return builtBy;
    +    }
    +
    +    @Override
    +    public String toString() {
    +        return coordinates.toString();
    +    }
    +
    +    public Date getBuildTimestampDate() {
    +        if (buildTimestamp != null && !buildTimestamp.isEmpty()) {
    +            try {
    +                SimpleDateFormat buildTimestampFormat = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'");
    +                Date buildTimestampDate = buildTimestampFormat.parse(buildTimestamp);
    +                return buildTimestampDate;
    +            } catch (ParseException parseEx) {
    +                return null;
    +            }
    +        } else {
    +            return null;
    +        }
    +    }
    +
    +    /**
    +     * Builder for BundleDetails.
    --- End diff --
    
    Please also javadoc the required properties on the Builder, since that the public i/f
that actually gets used.
    > + * the withCoordinates and withBundleFile properties are required


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message