metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mattf-horton <...@git.apache.org>
Subject [GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...
Date Wed, 09 Aug 2017 19:19:47 GMT
Github user mattf-horton commented on a diff in the pull request:

    https://github.com/apache/metron/pull/530#discussion_r132280796
  
    --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/bundle/BundleCoordinates.java
---
    @@ -0,0 +1,93 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.bundles.bundle;
    +
    +/**
    + * The coordinates of a bundle (group, artifact, version).
    + */
    +public class BundleCoordinates {
    +
    +    public static final String DEFAULT_GROUP = "default";
    +    public static final String DEFAULT_VERSION = "unversioned";
    +
    +    public static final BundleCoordinates UNKNOWN_COORDINATE = new BundleCoordinates(DEFAULT_GROUP,
"unknown", DEFAULT_VERSION);
    +
    +    private final String group;
    +    private final String id;
    +    private final String version;
    +    private final String coordinate;
    +
    +    public BundleCoordinates(final String group, final String id, final String version)
{
    +        this.group = isBlank(group) ? DEFAULT_GROUP : group;
    +        this.id = id;
    +        this.version = isBlank(version) ? DEFAULT_VERSION : version;
    +
    +        if (isBlank(id)) {
    +            throw new IllegalStateException("Id is required for BundleCoordinates");
    +        }
    +
    +        if(this.group.contains(":") || this.id.contains(":") || this.version.contains(":"))
{
    +            throw new IllegalStateException(String.format("Invalid coordinates: cannot
contain : character group[%s] id[%s] version[%s]",this.group,this.id,this.version));
    +        }
    +        this.coordinate = this.group + ":" + this.id + ":" + this.version;
    +    }
    +
    +    private boolean isBlank(String str) {
    +        return str == null || str.trim().length() == 0;
    +    }
    +
    +    public String getGroup() {
    +        return group;
    +    }
    +
    +    public String getId() {
    +        return id;
    +    }
    +
    +    public String getVersion() {
    +        return version;
    +    }
    +
    +    public final String getCoordinate() {
    --- End diff --
    
    Please rename this to getCoordinates() too, since it is public.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message