metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mattf-horton <...@git.apache.org>
Subject [GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...
Date Fri, 11 Aug 2017 23:50:04 GMT
Github user mattf-horton commented on a diff in the pull request:

    https://github.com/apache/metron/pull/530#discussion_r132798637
  
    --- Diff: bundles-lib/src/main/java/org/apache/metron/bundles/ExtensionManager.java ---
    @@ -0,0 +1,436 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.bundles;
    +
    +
    +import org.apache.commons.vfs2.FileObject;
    +import org.apache.commons.vfs2.FileSystemException;
    +import org.apache.commons.vfs2.FileSystemManager;
    +import org.apache.metron.bundles.bundle.Bundle;
    +import org.apache.metron.bundles.bundle.BundleCoordinates;
    +import org.apache.metron.bundles.bundle.BundleDetails;
    +import org.apache.metron.bundles.util.BundleProperties;
    +import org.apache.metron.bundles.util.FileUtils;
    +import org.apache.metron.bundles.util.StringUtils;
    +import org.apache.metron.bundles.annotation.behavior.RequiresInstanceClassLoading;
    +
    +import org.atteo.classindex.ClassIndex;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.io.IOException;
    +import java.lang.reflect.Modifier;
    +import java.net.URI;
    +import java.net.URISyntaxException;
    +import java.net.URL;
    +import java.net.URLClassLoader;
    +import java.util.*;
    +import java.util.concurrent.ConcurrentHashMap;
    +import java.util.concurrent.atomic.AtomicBoolean;
    +
    +/**
    + * Scans through the classpath to load all extension components using the service provider
API and
    + * running through all classloaders (root, BUNDLEs).
    + *
    + * @ThreadSafe - is immutable
    --- End diff --
    
    I'm worried about ExtensionManager.  It is effectively a fully static class, hence a de-facto
singleton.
    But the implementor seems under the impression that by making all top-level static fields
"final", that somehow makes it threadsafe.
    Which is blatantly untrue, since those fields contain data structures that are not immutable,
and in most cases not concurrent.
    
    Also, it probably currently works because it is only called once at startup time.  But
I'm concerned what happens if it gets called from multiple topologies running in the same
VM. And it certainly won't work for dynamic addition of bundles during runtime.
    
    Let me emphasize again: This class is NOT threadsafe.  @ottobackwards , if you believe
it needs to be threadsafe, then please do a reset and discuss with me how to fix this.  If
it's probably okay for current usages, then it is sufficient to mention it for improvement
in a jira.  Do you think METRON-1100 is an okay place for such mention, or should we open
another jira?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message