metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] metron pull request #712: Metron 1129
Date Wed, 23 Aug 2017 16:20:12 GMT
Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/712#discussion_r134799112
  
    --- Diff: metron-deployment/packaging/docker/rpm-docker/SPECS/metron.spec ---
    @@ -30,6 +30,8 @@
     %define metron_root         %{_prefix}/%{base_name}
     %define metron_home         %{metron_root}/%{full_version}
     
    +%define _binaries_in_noarch_packages_terminate_build   0
    --- End diff --
    
    Some of the Node dependencies have shell scripts.  The RPM builder would complain that
we are adding shell scripts that need /bin/sh into a 'noarch' RPM.  I had to turn this check
off to get the RPMs to build.  The other alternative would be to make this an arch-specific
RPM, but that doesn't seem necessary to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message