metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] metron pull request #709: METRON-1122: Add support for the profiler in the m...
Date Fri, 25 Aug 2017 13:55:34 GMT
Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/709#discussion_r135264143
  
    --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py
---
    @@ -251,6 +253,26 @@
     threat_intel_join_parallelism = config['configurations']['metron-enrichment-env']['threat_intel_join_parallelism']
     kafka_writer_parallelism = config['configurations']['metron-enrichment-env']['kafka_writer_parallelism']
     
    +# Profiler
    +
    +metron_profiler_topology = 'profiler'
    +profiler_input_topic = config['configurations']['metron-enrichment-env']['enrichment_output_topic']
    --- End diff --
    
    Its a good thing to bring up and discuss @merrimanr .  I agree with @cestella .  Doing
it this way makes it less error-prone for the user.  If the user changes the enrichment output
topic, the Profiler will get auto-magically updated too.  
    
    I cannot think of a use case where the Profiler does not want the output of Enrichment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message