metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From merrimanr <...@git.apache.org>
Subject [GitHub] metron pull request #711: METRON-1127: Add ability to escalate alerts for ex...
Date Tue, 29 Aug 2017 14:27:07 GMT
Github user merrimanr commented on a diff in the pull request:

    https://github.com/apache/metron/pull/711#discussion_r135806560
  
    --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/AlertServiceImpl.java
---
    @@ -0,0 +1,57 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.rest.service.impl;
    +
    +import com.fasterxml.jackson.core.JsonProcessingException;
    +import java.util.Map;
    +import org.apache.metron.common.utils.JSONUtils;
    +import org.apache.metron.rest.MetronRestConstants;
    +import org.apache.metron.rest.RestException;
    +import org.apache.metron.rest.service.AlertService;
    +import org.apache.metron.rest.service.KafkaService;
    +import org.springframework.beans.factory.annotation.Autowired;
    +import org.springframework.core.env.Environment;
    +import org.springframework.stereotype.Service;
    +
    +/**
    + * The default service layer implementation of {@link AlertService}.
    + *
    + * @see AlertService
    + */
    +@Service
    +public class AlertServiceImpl implements AlertService {
    +
    +  private Environment environment;
    +  private final KafkaService kafkaService;
    +
    +  @Autowired
    +  public AlertServiceImpl(final KafkaService kafkaService,
    +                          final Environment environment) {
    +    this.kafkaService = kafkaService;
    +    this.environment = environment;
    +  }
    +
    --- End diff --
    
    I was coming at it from a transactional perspective and trying to avoid a race condition
(alert changes after a client requests it and before it gets escalated).  I think a lot of
what you describe can already be done by chaining rest calls together.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message