metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iraghumitra <...@git.apache.org>
Subject [GitHub] metron pull request #691: METRON-1104: Build Failure - Due to Bootstrap vers...
Date Fri, 11 Aug 2017 16:32:59 GMT
GitHub user iraghumitra opened a pull request:

    https://github.com/apache/metron/pull/691

    METRON-1104: Build Failure - Due to Bootstrap version change

    ## Contributor Comments
    Hardcoding the version of bootstrap version to  4.0.0-alpha.6
    
    Bootstrap's latest version (4beta) removed some of the css files that we are using. The
package.json in metron-alerts is configured to pick the latest version of Bootstrap after
'4-alpha-6' of bootstrap for building the UI and hence there is a build failure. 
    
    In this PR I am hard coding the bootstrap version to '4-alpha-6'. We can move to Bootstrap
4Beta if required after fixing the failures. Also i noticed that the build version in package.json
file is mentioned as 0.4.0 I corrected it to 0.4.1
    
    After the fix the build should be passing and metron-alerts should be functional
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines
and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).

    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed
or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested
manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the
root metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

    - [x] Have you verified the basic functionality of the build by building and running locally
with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered
by building and verifying the site-book? If not then run the following commands and the verify
changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal
repository such that your branches are built there before submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/iraghumitra/incubator-metron METRON-1104

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/691.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #691
    
----
commit 10832a4b61385a1416e1606c739bc315b13e30a3
Author: iraghumitra <raghumitra.ksv@gmail.com>
Date:   2017-08-11T16:20:09Z

    Hardcoding the version of bootstrap version to  4.0.0-alpha.6

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message