metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] metron pull request #698: METRON-1111 Mislabeled Configuration Property in A...
Date Wed, 16 Aug 2017 18:24:30 GMT
GitHub user nickwallen opened a pull request:

    https://github.com/apache/metron/pull/698

    METRON-1111 Mislabeled Configuration Property in Ambari

    In Ambari there are two input boxes with the same caption 'Threat Intel Spout Parallelism'.
 I fixed the label to correctly identify each one.  I also re-phrased some of the other descriptions
to make them more clear.  This PR is completely underwhelming, I assure you.
    
    To test this change, launch the Full Dev environment and open Ambari.  Navigate to Metron
> Configs > Enrichment.  Ensure that there are two input boxes (among many) with the
following name and description.
    * Threat Intel Split Parallelism: Threat Intel Split Bolt Parallelism for the Enrichment
Topology
    * Threat Intel Stellar Parallelism: Threat Intel Stellar Bolt Parallelism for the Enrichment
Topology
    
    - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).

    - [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    - [ ] Have you included steps to reproduce the behavior or problem that is being changed
or addressed?
    - [ ] Have you included steps or a guide to how the change may be verified and tested
manually?
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the
root metron 
    - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

    - [ ] Have you verified the basic functionality of the build by building and running locally
with Vagrant full-dev environment or the equivalent?
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nickwallen/metron METRON-1111

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/698.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #698
    
----
commit 08f93d57c0554399c1809fe20f161cddcfc14b86
Author: Nick Allen <nick@nickallen.org>
Date:   2017-08-16T18:18:39Z

    METRON-1111 Mislabeled Configuration Property in Ambari

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message