metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] metron pull request #712: Metron 1129
Date Wed, 23 Aug 2017 16:09:33 GMT
GitHub user nickwallen opened a pull request:

    https://github.com/apache/metron/pull/712

    Metron 1129

    If you install the Management UI using the RPM, it will not install all of the required
Node dependencies.  You have to manually run `npm install ...` to get those dependencies installed.
 
    
    This works just fine in an environment that can access the interwebs.  This does not work
so well when installing in an offline environment with no interweb access.  If we package
all Node dependencies in the RPM itself, this makes it much simpler to install in an offline
environment.  And this, of course, will also work in an online environment and removes a manual
steps.  So win, win.
    
    ### Testing
    
    I tested this change in two ways.
    * I built the RPMs and then manually copied them to a raw CentOS box.  I installed Node
on the box, but did not install any dependencies with NPM.  I then installed the RPMs and
was able to launch the Management UI.  All dependencies were satisfied based on what was contained
in the RPM.
    * I launched Full Dev, which builds the RPMs and deploys them with the Mpack.  The Management
UI and all other core functions worked.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nickwallen/metron METRON-1129

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/712.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #712
    
----
commit adc65582ee88221537b2d2fef1ecd83f295bc326
Author: Nick Allen <nick@nickallen.org>
Date:   2017-08-22T22:57:32Z

    Packaging node deps in the RPMs

commit edb660f0de1e3de6751d98b7fa323b0df04b60c9
Author: Nick Allen <nick@nickallen.org>
Date:   2017-08-23T15:47:31Z

    Updates

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message