metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JonZeolla <...@git.apache.org>
Subject [GitHub] metron issue #712: METRON-1129 Management UI - Package Node Dependencies in ...
Date Sat, 02 Sep 2017 02:09:06 GMT
Github user JonZeolla commented on the issue:

    https://github.com/apache/metron/pull/712
  
    +1, spun up full dev and combed through the changes; all appears to be good.  Similarly
did some `rpmlint`ing:
    ```
    # rpmlint metron-config-0.4.1-201709020023.noarch.rpm  | grep -v script-without-shebang
| grep -v hidden-file-or-dir
    metron-config.noarch: I: enchant-dictionary-not-found en_US
    metron-config.noarch: W: no-documentation
    metron-config.noarch: E: zero-length /usr/metron/0.4.1/web/expressjs/node_modules/mime/.npmignore
    metron-config.noarch: W: non-standard-dir-in-usr metron
    metron-config.noarch: E: subsys-not-used /etc/init.d/metron-management-ui
    metron-config.noarch: W: incoherent-init-script-name metron-management-ui ('metron-config',
'metron-configd')
    ```
    
    After a bit of digging into the above `W` and `E`s, I think we should address the `subsys-not-used`
as a very simple follow-on, but otherwise this looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message