metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nickwallen <...@git.apache.org>
Subject [GitHub] metron pull request #731: METRON-1146 Refactor for ParserExtensionConfig and...
Date Wed, 06 Sep 2017 15:51:31 GMT
Github user nickwallen commented on a diff in the pull request:

    https://github.com/apache/metron/pull/731#discussion_r137309525
  
    --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/ExtensionServiceImpl.java
---
    @@ -528,20 +527,26 @@ private void rollBackPatternsFromHdfs(InstallContext context) throws
Exception{
       private void writeExtensionConfiguration(InstallContext context) throws Exception {
         ParserExtensionConfig config = new ParserExtensionConfig();
         config.setParserExtensionParserName(context.extensionParserNames);
    -    config.setExtensionsBundleID(context.bundleID.get());
    -    config.setExtensionsBundleVersion(context.bundleVersion.get());
    +    config.setExtensionIdentifier(context.extensionIdentifier.get());
    +    config.setExtensionBundleID(context.bundleID.get());
    +    config.setExtensionBundleVersion(context.bundleVersion.get());
         config.setExtensionBundleName(context.bundleName.get());
         config.setExtensionAssemblyName(context.extensionPackageName.get());
         config.setDefaultParserConfigs(context.defaultParserConfigs.get());
    -    config.setDefaultEnrichementConfigs(context.defaultEnrichmentConfigs.get());
    +    config.setDefaultEnrichmentConfigs(context.defaultEnrichmentConfigs.get());
         config.setDefaultIndexingConfigs(context.defaultIndexingConfigs.get());
         if(context.defaultElasticSearchTemplates.isPresent()) {
           config.setDefaultElasticSearchTemplates(context.defaultElasticSearchTemplates.get());
         }
    -    ConfigurationsUtils.writeParserExtensionConfigToZookeeper(context.extensionPackageName.get(),config.toJSON().getBytes(),
client);
    +    ConfigurationsUtils.writeParserExtensionConfigToZookeeper(context.extensionIdentifier.get(),config.toJSON().getBytes(),
client);
    --- End diff --
    
    What is the logic for changing package name to identifier?


---

Mime
View raw message