metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ottobackwards <...@git.apache.org>
Subject [GitHub] metron pull request #731: METRON-1146 Refactor for ParserExtensionConfig and...
Date Wed, 06 Sep 2017 16:14:40 GMT
Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/731#discussion_r137316439
  
    --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/ParserExtensionController.java
---
    @@ -90,8 +91,8 @@
       @ApiOperation(value = "Retrieves all ParserExtensionConfigs from Zookeeper")
       @ApiResponse(message = "Returns all ParserExtensionConfigs", code = 200)
       @RequestMapping(method = RequestMethod.GET)
    -  ResponseEntity<Map<String, ParserExtensionConfig>> findAll() throws RestException
{
    -    return new ResponseEntity<Map<String, ParserExtensionConfig>>(extensionService.getAllParserExtensions(),
HttpStatus.OK);
    +  ResponseEntity<List<ParserExtensionConfig>> findAll() throws RestException
{
    --- End diff --
    
    I have another branch where I am doing work on extending the management ui to manage extensions.
 I had a lot of trouble consuming the maps.  The map is the configurations with a field pulled
out as the key, so making it a list made it work, similar to the getAll for parser configurations,
and really didn't lose anything.
    
    TL;DR
    I am not good enough at angular to consume the maps correctly so I refactored.


---

Mime
View raw message