metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ottobackwards <...@git.apache.org>
Subject [GitHub] metron pull request #740: METRON-1167 Define Session Specific Global Configu...
Date Fri, 08 Sep 2017 18:52:19 GMT
Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/740#discussion_r137864851
  
    --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/shell/StellarShell.java
---
    @@ -308,17 +315,68 @@ private void handleMagic( String rawExpression) {
                   .collect(Collectors.joining(", "));
           writeLine(functions);
     
    -    } else if(MAGIC_VARS.equals(command)) {
    +    } else if (MAGIC_VARS.equals(command)) {
     
    -      // list all variables
    +      // '%vars' -> list all variables in scope
           executor.getVariables()
    -              .forEach((k,v) -> writeLine(String.format("%s = %s", k, v)));
    +              .forEach((k, v) -> writeLine(String.format("%s = %s", k, v)));
    +
    +    } else if (MAGIC_GLOBALS.equals(command)) {
    +
    +      // '%globals' -> list all globals in scope
    +      Map<String, Object> globals = Collections.emptyMap();
    --- End diff --
    
    Nick. If I understand correctly, if there is no ZK, then this turns on the GLOBAL_CONFIG
flag, and sets whatever properties.
    
    Is there any risk that other functions that check for GLOBAL_CONFIG can see the flag,
but assuming the full config is present, when in this case only what the user has set is present?
    



---

Mime
View raw message