metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From merrimanr <...@git.apache.org>
Subject [GitHub] metron pull request #737: METRON-1161: Add ability to edit parser command li...
Date Tue, 19 Sep 2017 20:57:55 GMT
Github user merrimanr commented on a diff in the pull request:

    https://github.com/apache/metron/pull/737#discussion_r139815871
  
    --- Diff: metron-interface/metron-config/src/app/sensors/sensor-parser-config/sensor-parser-config.component.ts
---
    @@ -409,12 +403,17 @@ export class SensorParserConfigComponent implements OnInit {
         this.showFieldSchema = (pane === Pane.FIELDSCHEMA) ? visibilty : false;
         this.showRawJson = (pane ===  Pane.RAWJSON) ? visibilty : false;
         this.showThreatTriage = (pane ===  Pane.THREATTRIAGE) ? visibilty : false;
    +    this.showStormSettings = (pane === Pane.STORMSETTINGS) ? visibilty : false;
       }
     
       onRawJsonChanged(): void {
         this.sensorFieldSchema.createFieldSchemaRows();
       }
     
    +  onStormSettingsChanged(): void {
    --- End diff --
    
    Yes this was a mistake.  I think we should leave this function in the event we need it
in the future but I will definitely remove this logging.


---

Mime
View raw message