metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From merrimanr <...@git.apache.org>
Subject [GitHub] metron pull request #779: METRON-1218: Metron REST should return better erro...
Date Fri, 29 Sep 2017 21:43:15 GMT
Github user merrimanr commented on a diff in the pull request:

    https://github.com/apache/metron/pull/779#discussion_r141974727
  
    --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
    @@ -45,4 +45,14 @@ private HttpStatus getStatus(HttpServletRequest request) {
         }
         return HttpStatus.valueOf(statusCode);
       }
    +
    +  private String getFullMessage(Throwable ex) {
    +    String fullMessage = ex.getMessage();
    +    Throwable cause = ex.getCause();
    +    while(cause != null) {
    +      fullMessage = cause.getMessage();
    +      cause = cause.getCause();
    +    }
    +    return fullMessage;
    --- End diff --
    
    The log level is indeed INFO and it should not be.  That regression was introduced when
we added ${HBASE_HOME}/conf to the REST classpath because that directory contains a log4j.properties
file with logging set to INFO.  I'm planning on fixing that in a separate PR.  I'm not sure
that's the cause here though because I'm able to produce an error in the logs with the same
type of error (InvalidSearchException).
    
    Are you sure you have the code in this PR deployed properly?  Your stack trace says the
exception was thrown at line 170 but in this PR the exception is thrown at line 176.


---

Mime
View raw message