metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ottobackwards <...@git.apache.org>
Subject [GitHub] metron pull request #731: METRON-1146 Refactor for ParserExtensionConfig and...
Date Sun, 03 Sep 2017 03:28:42 GMT
GitHub user ottobackwards opened a pull request:

    https://github.com/apache/metron/pull/731

    METRON-1146  Refactor for ParserExtensionConfig and Rest get all call

    This a PR for some cleanup on the 1136 Feature Branch
    
    - return a list from GET ( getAllParsers ) and not a map.
    - fix names in Parser Extension Configs to be consistant with extension/extensions
    - add a field just called identifier, to be used instead of assembly name
    - differentiate identifier/assemblyname
    
    ## 
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).

    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the
root metron 
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] Have you verified the basic functionality of the build by building and running locally
with Vagrant full-dev environment or the equivalent?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ottobackwards/metron ext-refactor-names-getall

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/731.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #731
    
----
commit 0d3b4c01fa41a3ee888a4debf249e62f82f2a184
Author: Otto Fowler <ottobackwards@gmail.com>
Date:   2017-09-03T03:17:46Z

    Refactor:
    
    - return a list from GET ( getAllParsers ) and not a map.
    - fix names in Parser Extension Configs to be consistant with extension/extensions
    - add a field just called identifier, to be used instead of assembly name
    - differentiate identifier/assemblyname

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message