metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From merrimanr <>
Subject [GitHub] metron pull request #737: METRON-1161: Add ability to edit parser command li...
Date Fri, 08 Sep 2017 13:42:56 GMT
GitHub user merrimanr opened a pull request:

    METRON-1161: Add ability to edit parser command line options in the management UI

    ## Contributor Comments
    This PR is a follow up to and exposes the new
Storm parser topology options in the Management UI.  This can be verified in full dev by navigating
to the Management UI and editing any parser.  There should be a new "Storm Settings" pane
in the primary panel that can be expanded and exposes input controls for all the new parser
topology properties.  Editing these should successfully change the parser configs in zookeeper.
    I also performed a slight refactor of the Raw JSON editor to make it easier to maintain
as we add more parser config properties.
    ## Pull Request Checklist
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](
for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](
for complete smoke testing guides.  
    In order to streamline the review of the contribution we ask you follow these guidelines
and ask you to double check the following:
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](

    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed
or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested
    - [x] Have you ensured that the full suite of tests and checks have been executed in the
root metron folder via:
      mvn -q clean integration-test install && build_utils/ 
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](

    - [x] Have you verified the basic functionality of the build by building and running locally
with Vagrant full-dev environment or the equivalent?
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered
by building and verifying the site-book? If not then run the following commands and the verify
changes via `site-book/target/site/index.html`:
      cd site-book
      mvn site
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci]( is set up for your personal
repository such that your branches are built there before submitting a pull request.

You can merge this pull request into a Git repository by running:

    $ git pull METRON-1161

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #737
commit 3b2a7a36443ab8c5599223951dc9d25f587d3ca0
Author: merrimanr <>
Date:   2017-09-06T21:20:49Z

    initial commit

commit dd3d44cdece6d553444f838891b33010491f99fa
Author: merrimanr <>
Date:   2017-09-07T19:24:29Z

    added new properties to readme panel and updated tests



View raw message