metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From merrimanr <...@git.apache.org>
Subject [GitHub] metron pull request #777: METRON-1207: Make RPMs for Alerts UI
Date Thu, 28 Sep 2017 14:11:23 GMT
GitHub user merrimanr opened a pull request:

    https://github.com/apache/metron/pull/777

    METRON-1207: Make RPMs for Alerts UI

    ## Contributor Comments
    This PR creates an RPM for the Alerts UI.  To test, cd to metron-deployment and run `mvn
clean package -Pbuild-rpms`.  This should result in "metron-alerts-0.4.1-*.noarch.rpm" being
written to 
    packaging/docker/rpm-docker/RPMS/noarch/metron.  This can be tested further by copying
the rpm to node1 in full dev and installing with `rpm -i metron-alerts-0.4.1-*.noarch.rpm`.
 This should write:
    
    - several front end assets to $METRON_HOME/web/alerts-ui
    - an `alerts-server.js` file to $METRON_HOME/web/expressjs
    - a `metron-alerts` init script to /etc/init.d/metron-alerts-ui
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines
and ask you to double check the following:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).

    - [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed
or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested
manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the
root metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

    - [x] Have you verified the basic functionality of the build by building and running locally
with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered
by building and verifying the site-book? If not then run the following commands and the verify
changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal
repository such that your branches are built there before submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/merrimanr/incubator-metron METRON-1207

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/777.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #777
    
----
commit a8437e86ac36806cc9b4ed2c031509af13ba478a
Author: merrimanr <merrimanr@gmail.com>
Date:   2017-09-26T21:17:33Z

    initial commit

commit 88e77f08d4fc4c096fb1081af813dd11b8d7f07b
Author: merrimanr <merrimanr@gmail.com>
Date:   2017-09-26T21:33:31Z

    initial commit

commit 18965553aa5ec2855ef5815f27be212f0cb2df18
Author: merrimanr <merrimanr@gmail.com>
Date:   2017-09-28T13:46:06Z

    Merge remote-tracking branch 'mirror/master' into METRON-1207

commit 811cd1321905dd49fa0e224e85f99ac51d8e4aae
Author: merrimanr <merrimanr@gmail.com>
Date:   2017-09-28T13:58:51Z

    resolved merge conflicts

----


---

Mime
View raw message