metron-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cestella <...@git.apache.org>
Subject [GitHub] metron pull request #781: METRON-1052:
Date Fri, 29 Sep 2017 16:46:58 GMT
GitHub user cestella opened a pull request:

    https://github.com/apache/metron/pull/781

    METRON-1052: 

    ## Contributor Comments
    This is a follow-on to METRON-539. Currently we have Stellar functions to perform cryptographic
hashing operations. It would be useful to expand this to support forensic similarity hash
functions so we could compare the similarity of inputs.  I have added support in this PR for
[TLSH](https://github.com/trendmicro/tlsh/blob/master/TLSH_CTC_final.pdf)
    
    This fits well within the existing `HASH` abstractions.  I have expanded and generalized
it in a few places, but I think it's all within the spirit of the thing.
    
    I owe a use-case driven walk-through of a demo that I designed, but haven't written up
yet.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines
and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at
[Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).

    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed
or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested
manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the
root metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

    - [x] Have you verified the basic functionality of the build by building and running locally
with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered
by building and verifying the site-book? If not then run the following commands and the verify
changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal
repository such that your branches are built there before submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cestella/incubator-metron METRON-1052-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/781.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #781
    
----
commit 1852d1089c401db8c735fc7b1bff5f385ba612f8
Author: cstella <cestella@gmail.com>
Date:   2017-09-29T16:41:25Z

    Shored up documentation a bit.

commit 2cb04cfaf360dae1041a51f649a51269b033df3e
Author: cstella <cestella@gmail.com>
Date:   2017-09-29T16:41:32Z

    Whoops, forgot one bit.

----


---

Mime
View raw message